Feature/configure win app dir #393
Merged
+300
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ppDir Allow Windows app installs to use a custom directory (e.g., AppData\Local\Programs) instead of the hardcoded ~/.jdeploy/apps path, controlled by the jdeploy.winAppDir property in package.json. Falls back to .jdeploy/apps if unset for backward compat. All lookup paths (update detection, uninstall, tray controller) check both configured and legacy locations.
… changes
During install/update, delete the old .jdeploy/apps/{fqpn} directory if the
configured winAppDir resolves to a different location. Persist winAppDir to a
file next to the uninstaller so registry-triggered uninstalls can find both
the configured and legacy app directories. This handles pre-manifest installs
that cannot rely on uninstall manifests for path discovery.
- Simplify ServiceTrayController.getInstallDir() to return jdeploy home since it's only used for AI asset resolution (skills, agents), not the app install directory - Guard winAppDir cleanup in UninstallService behind Windows platform check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.