Add Windows Authenticode signing support via environment variables#443
Merged
Add Windows Authenticode signing support via environment variables#443
Conversation
Documents the black-box specification for the Authenticode signing support added in PR #431, including environment variable configuration, supported keystore types (PFX, JKS, PKCS#11), and usage examples. https://claude.ai/code/session_01Vwovc4eQee9KZ5LmUSJyqv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for signing Windows
.exebundles with Authenticode signatures during the jDeploy packaging step. Signing is configured entirely through environment variables and supports both local keystores (PFX/PKCS12, JKS) and hardware security modules via PKCS#11.Key Changes
rfc/windows-authenticode-signing.md) that specifies:JDEPLOY_WIN_KEYSTORE_PATH,JDEPLOY_WIN_KEYSTORE_PASSWORD, etc.)Implementation Details
The RFC outlines the following architecture:
WindowsSigningConfig— configuration POJO with validationWindowsSigningConfigFactory— reads environment variablesWindowsSigningService— performs actual signing via jsignPackageService.signWindowsExeIfConfigured()called after bundle creationThis enables developers to automatically sign Windows releases without modifying
package.json, improving end-user installation experience by reducing SmartScreen warnings and antivirus flags.https://claude.ai/code/session_01Vwovc4eQee9KZ5LmUSJyqv