Remove "/releases" suffix from GitHub releases URL construction#448
Merged
Remove "/releases" suffix from GitHub releases URL construction#448
Conversation
…rator The getReleasesUrl() method appended "/releases" to the repository URL when setting the publish target. GitHubPublishDriver expects a bare repo URL and appends "/releases/download/..." itself, causing a duplicate path like .../repo-releases/releases/releases/download/... which returns 404. Fixes #447 https://claude.ai/code/session_01EniKoD4HJUhUFssUo34PgQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the
getReleasesUrl()method to remove the hardcoded "/releases" path suffix from GitHub repository URLs. The method now returns the base repository URL instead of appending the releases endpoint path.Changes
+ "/releases"suffix from the private repository URL construction+ "/releases"suffix from the public repository URL constructionDetails
This change simplifies the URL generation by having
getReleasesUrl()return only the repository base URL. The "/releases" path segment is now expected to be appended by the caller or handled elsewhere in the application logic. This provides more flexibility in how the releases endpoint is constructed and used throughout the codebase.https://claude.ai/code/session_01EniKoD4HJUhUFssUo34PgQ