Skip to content

Remove "/releases" suffix from GitHub releases URL construction#448

Merged
shannah merged 1 commit intomasterfrom
claude/review-github-discussion-Yotm2
Mar 26, 2026
Merged

Remove "/releases" suffix from GitHub releases URL construction#448
shannah merged 1 commit intomasterfrom
claude/review-github-discussion-Yotm2

Conversation

@shannah
Copy link
Copy Markdown
Owner

@shannah shannah commented Mar 25, 2026

Summary

Updated the getReleasesUrl() method to remove the hardcoded "/releases" path suffix from GitHub repository URLs. The method now returns the base repository URL instead of appending the releases endpoint path.

Changes

  • Removed + "/releases" suffix from the private repository URL construction
  • Removed + "/releases" suffix from the public repository URL construction

Details

This change simplifies the URL generation by having getReleasesUrl() return only the repository base URL. The "/releases" path segment is now expected to be appended by the caller or handled elsewhere in the application logic. This provides more flexibility in how the releases endpoint is constructed and used throughout the codebase.

https://claude.ai/code/session_01EniKoD4HJUhUFssUo34PgQ

…rator

The getReleasesUrl() method appended "/releases" to the repository URL
when setting the publish target. GitHubPublishDriver expects a bare repo
URL and appends "/releases/download/..." itself, causing a duplicate path
like .../repo-releases/releases/releases/download/... which returns 404.

Fixes #447

https://claude.ai/code/session_01EniKoD4HJUhUFssUo34PgQ
@shannah shannah merged commit 84a6be0 into master Mar 26, 2026
17 checks passed
@shannah shannah deleted the claude/review-github-discussion-Yotm2 branch March 26, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants