fix: deployment by disabling sourcemaps until we find a solution - #10261
fix: deployment by disabling sourcemaps until we find a solution#10261NeOMakinG wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughThe Vite build configuration was updated to always disable sourcemaps by setting build.sourcemap to false, removing any mode- or environment-based variability. No other configuration logic or exports were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
vite.config.mts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/naming-conventions.mdc)
**/*: ALWAYS use appropriate file extensions
Flag files without kebab-case
Files:
vite.config.mts
🧠 Learnings (1)
📓 Common learnings
Learnt from: NeOMakinG
PR: shapeshift/web#10231
File: src/components/AssetSearch/components/AssetList.tsx:2-2
Timestamp: 2025-08-08T15:00:49.838Z
Learning: Project shapeshift/web: NeOMakinG prefers avoiding minor a11y/UI nitpicks (e.g., adding aria-hidden to decorative icons in empty states like src/components/AssetSearch/components/AssetList.tsx) within feature PRs; defer such suggestions to a follow-up instead of blocking the PR.
Learnt from: NeOMakinG
PR: shapeshift/web#10231
File: src/components/MultiHopTrade/components/TradeInput/components/HighlightedTokens.tsx:14-14
Timestamp: 2025-08-08T15:00:22.292Z
Learning: In shapeshift/web reviews for NeOMakinG, avoid nitpicks to change deep-relative imports to '@/…' alias paths within feature/non-refactor PRs; defer such style-only changes to a dedicated follow-up refactor unless they fix an issue.
Learnt from: gomesalexandre
PR: shapeshift/web#10232
File: packages/unchained-client/openapitools.json:61-61
Timestamp: 2025-08-08T10:23:16.829Z
Learning: In shapeshift/web, for temporary “monkey patch” PRs (e.g., packages/unchained-client/openapitools.json using jsDelivr CDN refs like cosmos/mayachain), gomesalexandre is fine with branch-based URLs and does not want SHA pinning. Treat this as a scoped exception to their general preference for pinned dependencies/refs.
🔇 Additional comments (2)
vite.config.mts (2)
173-174: Sourcemaps disabled globally — aligns with the objective to unblock deploymentsSetting build.sourcemap to false (Line 173) is a safe, low-risk way to reduce build artifacts and should resolve deployment blockers from oversized maps.
138-139: Verify CI sourcemap upload and symbolicationI ran searches for Sentry CLI usage, sourcemap upload flags, Sentry env vars, and Vite Sentry plugins but didn’t find any references in the repo. However, disabling sourcemaps in Vite (Line 173) could still impact external CI steps that upload maps and perform symbolication.
Please manually verify your CI pipelines (e.g.,
.github/workflows/,ci/, etc.) to ensure there are no lingeringsentry-cli upload-sourcemapsor similar steps. If such steps exist, you may want to:
- Wrap them in an environment‐flag check (for example, only run when
SOURCEMAPS=true).- Update documentation or alert stakeholders about the reduced quality of stack traces with sourcemaps disabled.
| }, | ||
| minify: mode === 'development' && !process.env.DEPLOY ? false : 'esbuild', | ||
| sourcemap: mode === 'development' && !process.env.DEPLOY ? 'inline' : true, | ||
| sourcemap: false, |
There was a problem hiding this comment.
we should still have the sourcemaps for debugging in local dev
| sourcemap: false, | |
| sourcemap: mode === 'development' && !process.env.DEPLOY ? 'inline' : false, |
|
#10263 this should do the trick. Deploying and not seeing anything weird if you want to take a quick second look |
Thanks for diving into this, closing it |
Description
Disable sourcemaps so we can deploy on envs until we find a way to reduce the sourcemap size
hdwallet seems to be taking 8mb of size from the sourcemap, but when I try to extract it to its own chunk, the import order is borken
Issue (if applicable)
Spotted by @gomesalexandre on discord
Risk
Low
Testing
Deploying on any env is fine!
I'll deploy on neo
Engineering
Operations
Screenshots (if applicable)
https://github.com/shapeshift/web/actions/runs/16914093094 should be 🟢
Summary by CodeRabbit