Skip to content

fix: update swagger link for mayachain - #10795

Merged
kaladinlight merged 1 commit into
developfrom
mayachain-swagger
Oct 10, 2025
Merged

fix: update swagger link for mayachain#10795
kaladinlight merged 1 commit into
developfrom
mayachain-swagger

Conversation

@kaladinlight

@kaladinlight kaladinlight commented Oct 10, 2025

Copy link
Copy Markdown
Member

Description

Fix generate script with updated swagger endpoint for mayachain.

Issue (if applicable)

N/A

Risk

High Risk PRs Require 2 approvals

Low

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Ensure yarn build:packages works again

Engineering

☝️

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

N/A

Screenshots (if applicable)

Summary by CodeRabbit

  • Chores

    • Updated the OpenAPI generator configuration for Mayachain to fetch the schema from a Git repository source instead of a CDN.
  • Impact

    • Improves reliability and freshness of the generated client.
    • No functional changes to the SDK or app behavior.
    • No action required for users.

@kaladinlight
kaladinlight requested a review from a team as a code owner October 10, 2025 18:56
@coderabbitai

coderabbitai Bot commented Oct 10, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Updated the mayachain OpenAPI generator configuration to change the inputSpec URL from a jsDelivr CDN link to a raw GitHub URL. No other generator settings were modified.

Changes

Cohort / File(s) Summary
OpenAPI generator config
packages/unchained-client/openapitools.json
Switched mayachain inputSpec from https://cdn.jsdelivr.net/.../mayachain/api/swagger.json to https://raw.githubusercontent.com/.../mayachain/api/swagger.json; all other settings unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • premiumjibles
  • 0xApotheosis

Poem

I twitch my whiskers, URLs align,
From CDN winds to raw GitHub vine.
Hop-hop, the spec now fresh and clear,
Swagger trails draw ever near.
Ears up, paws down—commit so fine! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title concisely describes the primary change by indicating the swagger link update for Mayachain, directly matching the pull request’s purpose of fixing the generator configuration.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mayachain-swagger

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between bd62f7d and 836e408.

📒 Files selected for processing (1)
  • packages/unchained-client/openapitools.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*

📄 CodeRabbit inference engine (.cursor/rules/naming-conventions.mdc)

**/*: ALWAYS use appropriate file extensions
Flag files without kebab-case

Files:

  • packages/unchained-client/openapitools.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Call / Static
🔇 Additional comments (1)
packages/unchained-client/openapitools.json (1)

230-240: Raw GitHub spec URL LGTM

Pointing inputSpec straight at the mayachain branch on raw GitHub is a solid fix and keeps the generator consistent with our other stacks. Looks good to me.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gomesalexandre gomesalexandre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm yarn && yarn build:packages && yarn && yarn dev is a happy camper!

image

And smoke checked the yarn && yarn dev part of this is similarly happy re: app running!

@kaladinlight
kaladinlight merged commit 1af73ab into develop Oct 10, 2025
4 checks passed
@kaladinlight
kaladinlight deleted the mayachain-swagger branch October 10, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants