feat: increase swapper timeouts

[gomesalexandre]

Description

This PR:

• increases swapper bulk quotes timeout to 10s, to accommodate for the whole quote flow (quote fetching + gas calcs) taking longer than 5s
• also adds additional 5s to the quotes refetch interval (20 -> 25s) to accommoodate for the additional 5s on the former and avoid cases where quotes would feel like they refetch too fast now

Issue (if applicable)

closes #11072

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low/Medium, it's swapper after all

Testing

• Ensure quotes still refetch, although with a 25s timeout now vs. 20 previously

Engineering

• ^
• Try and get a few Near Intents quotes and ensure these are now not rugged by timeouts

Operations

• 🏁 My feature is behind a flag and doesn't require operations testing (yet)

• ^

Screenshots (if applicable)

https://jam.dev/c/7b9f88d0-41c4-487d-b6d7-44dd0291e4d5

Summary by CodeRabbit

• Performance
  • Adjusted trade quote refresh interval timing for optimized polling.
  • Extended timeout for bulk rate fetch operations to improve reliability.

[coderabbitai]

📝 Walkthrough

Walkthrough

Two timeout and polling interval constants are increased: trade quote refresh interval from 20 to 25 seconds and swapper bulk fetch rate timeout from 5 to 10 seconds. No logic or control flow modifications.

Changes

Cohort / File(s)	Change Summary
Trade Quote Polling src/components/MultiHopTrade/hooks/useGetTradeQuotes/hooks/useGlobalQuotePolling.ts	Increased TRADE_QUOTE_REFRESH_INTERVAL_MS constant from 20,000 ms to 25,000 ms
Swapper API Timeout src/state/apis/swapper/swapperApi.ts	Increased BULK_FETCH_RATE_TIMEOUT_MS constant from 5,000 ms to 10,000 ms

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

These are straightforward constant value updates with no accompanying logic changes or side effects to verify.

Possibly related PRs

• feat: allow quotes that take longer than 5 seconds to keep going if we get nothing else #10372: Introduces timeout/fallback logic for bulk-rate operations that directly interacts with the BULK_FETCH_RATE_TIMEOUT_MS timeout being increased in this PR.

Suggested reviewers

• premiumjibles
• 0xApotheosis
• NeOMakinG

Poem

🐰 Whiskers twitching, numbers tweak—
More time for quotes, no longer weak!
Twenty to twenty-five, five to ten,
Better quotes found again and again! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'feat: increase swapper timeouts' directly and clearly describes the primary changes made: increasing timeout values in swapper-related files.
Linked Issues check	✅ Passed	The PR fulfills the acceptance criteria from issue #11072 by increasing the swapper quote timeout from 5s to 10s to accommodate the full quote + gas estimation flow, and also increases the refetch interval.
Out of Scope Changes check	✅ Passed	All changes in the PR are directly related to the objective of increasing swapper timeouts: TRADE_QUOTE_REFRESH_INTERVAL_MS and BULK_FETCH_RATE_TIMEOUT_MS updates align with the stated goals.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat_swapper_bump_timeout

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d5bf283 and 57d0cac.

📒 Files selected for processing (2)

• src/components/MultiHopTrade/hooks/useGetTradeQuotes/hooks/useGlobalQuotePolling.ts (1 hunks)
• src/state/apis/swapper/swapperApi.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (8)

📓 Common learnings

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10569
File: src/plugins/walletConnectToDapps/components/WalletConnectSigningModal/WalletConnectModalSigningFooter.tsx:121-129
Timestamp: 2025-09-17T22:40:30.149Z
Learning: gomesalexandre maintains strict scope discipline even for style/UI PRs in shapeshift/web, declining functionally correct UX improvements (like keeping Cancel button enabled during gas simulation loading) when they fall outside the PR's stated styling objectives, demonstrating his consistent pattern of deferring valid but tangential improvements to separate efforts.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10985
File: packages/swapper/src/swappers/PortalsSwapper/getPortalsTradeQuote/getPortalsTradeQuote.ts:0-0
Timestamp: 2025-11-03T22:31:30.786Z
Learning: In packages/swapper/src/swappers/PortalsSwapper, the rate and quote files intentionally use different approaches for calculating buyAmountBeforeSlippageCryptoBaseUnit: getPortalsTradeRate.tsx uses minOutputAmount / (1 - buffer) for conservative estimates, while getPortalsTradeQuote.ts uses outputAmount / (1 - buffer) for final quote display. This difference is validated by on-chain simulation testing and is intentional.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10206
File: src/config.ts:127-128
Timestamp: 2025-08-07T11:20:44.614Z
Learning: gomesalexandre prefers required environment variables without default values in the config file (src/config.ts). They want explicit configuration and fail-fast behavior when environment variables are missing, rather than having fallback defaults.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10461
File: src/plugins/walletConnectToDapps/components/modals/ContractInteractionBreakdown.tsx:0-0
Timestamp: 2025-09-13T16:45:18.813Z
Learning: gomesalexandre prefers aggressively deleting unused/obsolete code files ("ramboing") rather than fixing technical issues in code that won't be used, demonstrating his preference for keeping codebases clean and PR scope focused.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10458
File: src/plugins/walletConnectToDapps/types.ts:7-7
Timestamp: 2025-09-10T15:34:29.604Z
Learning: gomesalexandre is comfortable relying on transitive dependencies (like abitype through ethers/viem) rather than explicitly declaring them in package.json, preferring to avoid package.json bloat when the transitive dependency approach works reliably in practice.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10503
File: .env:56-56
Timestamp: 2025-09-16T13:17:02.938Z
Learning: gomesalexandre prefers to enable feature flags globally in the base .env file when the intent is to activate features everywhere, even when there are known issues like crashes, demonstrating his preference for intentional global feature rollouts over cautious per-environment enablement.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10249
File: src/pages/ThorChainLP/components/ReusableLpStatus/TransactionRow.tsx:447-503
Timestamp: 2025-08-13T17:07:10.763Z
Learning: gomesalexandre prefers relying on TypeScript's type system for validation rather than adding defensive runtime null checks when types are properly defined. They favor a TypeScript-first approach over defensive programming with runtime validations.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10276
File: src/hooks/useActionCenterSubscribers/useThorchainLpDepositActionSubscriber.tsx:61-66
Timestamp: 2025-08-14T17:51:47.556Z
Learning: gomesalexandre is not concerned about structured logging and prefers to keep console.error usage as-is rather than implementing structured logging patterns, even when project guidelines suggest otherwise.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10413
File: src/components/Modals/FiatRamps/fiatRampProviders/onramper/utils.ts:29-55
Timestamp: 2025-09-02T14:26:19.028Z
Learning: gomesalexandre prefers to keep preparatory/reference code simple until it's actively consumed, rather than implementing comprehensive error handling, validation, and robustness improvements upfront. They prefer to add these improvements when the code is actually being used in production.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10276
File: src/pages/ThorChainLP/components/ReusableLpStatus/TransactionRow.tsx:396-402
Timestamp: 2025-08-14T17:55:57.490Z
Learning: gomesalexandre is comfortable with functions/variables that return undefined or true (tri-state) when only the truthy case matters, preferring to rely on JavaScript's truthy/falsy behavior rather than explicitly returning boolean values.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10783
File: src/context/ModalStackProvider/useModalRegistration.ts:30-41
Timestamp: 2025-10-16T11:14:40.657Z
Learning: gomesalexandre prefers to add lint rules (like typescript-eslint/strict-boolean-expressions for truthiness checks on numbers) to catch common issues project-wide rather than relying on code review to catch them.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10206
File: src/lib/moralis.ts:47-85
Timestamp: 2025-08-07T11:22:16.983Z
Learning: gomesalexandre prefers console.error over structured logging for Moralis API integration debugging, as they find it more conventional and prefer to examine XHR requests directly rather than rely on structured logs for troubleshooting.

📚 Learning: 2025-08-08T11:40:55.734Z

Learnt from: NeOMakinG
Repo: shapeshift/web PR: 10234
File: src/components/MultiHopTrade/components/TradeConfirm/TradeConfirm.tsx:41-41
Timestamp: 2025-08-08T11:40:55.734Z
Learning: In MultiHopTrade confirm flow (src/components/MultiHopTrade/components/TradeConfirm/TradeConfirm.tsx and related hooks), there is only one active trade per flow. Because of this, persistent (module/Redux) dedupe for QuotesReceived in useTrackTradeQuotes is not necessary; the existing ref-based dedupe is acceptable.

Applied to files:

• src/components/MultiHopTrade/hooks/useGetTradeQuotes/hooks/useGlobalQuotePolling.ts

📚 Learning: 2025-07-29T15:04:28.083Z

Learnt from: NeOMakinG
Repo: shapeshift/web PR: 10139
File: src/components/MultiHopTrade/components/TradeConfirm/components/ExpandableStepperSteps.tsx:109-115
Timestamp: 2025-07-29T15:04:28.083Z
Learning: In src/components/MultiHopTrade/components/TradeConfirm/components/ExpandableStepperSteps.tsx, the component is used under an umbrella that 100% of the time contains the quote, making the type assertion `activeTradeQuote?.steps[currentHopIndex] as TradeQuoteStep` safe. Adding conditional returns before hooks would violate React's Rules of Hooks.

Applied to files:

• src/components/MultiHopTrade/hooks/useGetTradeQuotes/hooks/useGlobalQuotePolling.ts

📚 Learning: 2025-11-03T22:31:30.786Z

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10985
File: packages/swapper/src/swappers/PortalsSwapper/getPortalsTradeQuote/getPortalsTradeQuote.ts:0-0
Timestamp: 2025-11-03T22:31:30.786Z
Learning: In packages/swapper/src/swappers/PortalsSwapper, the rate and quote files intentionally use different approaches for calculating buyAmountBeforeSlippageCryptoBaseUnit: getPortalsTradeRate.tsx uses minOutputAmount / (1 - buffer) for conservative estimates, while getPortalsTradeQuote.ts uses outputAmount / (1 - buffer) for final quote display. This difference is validated by on-chain simulation testing and is intentional.

Applied to files:

• src/components/MultiHopTrade/hooks/useGetTradeQuotes/hooks/useGlobalQuotePolling.ts

📚 Learning: 2025-08-11T09:46:41.060Z

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10219
File: src/components/MultiHopTrade/components/TradeInput/TradeInput.tsx:167-172
Timestamp: 2025-08-11T09:46:41.060Z
Learning: In the shapeshift/web repository, the display cache logic for trade quotes (using `selectUserAvailableTradeQuotes` and `selectUserUnavailableTradeQuotes`) is intentionally kept the same between `TradeInput.tsx` and `TradeQuotes.tsx` components. The `hasQuotes` computation in `TradeInput.tsx` uses these display cache selectors by design, matching the pattern used in `TradeQuotes.tsx`.

Applied to files:

• src/components/MultiHopTrade/hooks/useGetTradeQuotes/hooks/useGlobalQuotePolling.ts

📚 Learning: 2025-08-10T21:09:25.643Z

Learnt from: premiumjibles
Repo: shapeshift/web PR: 10215
File: src/components/MultiHopTrade/hooks/useGetTradeRateInput.ts:65-67
Timestamp: 2025-08-10T21:09:25.643Z
Learning: In the MultiHopTrade components, `selectInputBuyAsset` and `selectInputSellAsset` selectors from `tradeInputSlice` always return defined values because they have default values in the initial state (BTC for buyAsset, ETH for sellAsset, with fallback to defaultAsset). Null checks for these assets are unnecessary when using these selectors.

Applied to files:

• src/components/MultiHopTrade/hooks/useGetTradeQuotes/hooks/useGlobalQuotePolling.ts

📚 Learning: 2025-11-12T12:48:02.977Z

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 11016
File: packages/swapper/src/swappers/NearIntentsSwapper/swapperApi/getTradeQuote.ts:93-93
Timestamp: 2025-11-12T12:48:02.977Z
Learning: In the swapper architecture, timeout handling is implemented at the abstraction layer in packages/swapper/src/swapper.ts using timeoutMonadic, which wraps all calls to individual swapper implementations. Individual swapper implementations (e.g., NearIntentsSwapper, PortalsSwapper, etc.) should NOT use timeoutMonadic directly—they simply return their results and the abstraction layer handles timeout concerns centrally.

Applied to files:

• src/state/apis/swapper/swapperApi.ts

📚 Learning: 2025-08-22T13:02:38.078Z

Learnt from: NeOMakinG
Repo: shapeshift/web PR: 10323
File: src/pages/Explore/Explore.tsx:91-92
Timestamp: 2025-08-22T13:02:38.078Z
Learning: In the ShapeShift web codebase, feature flags are consistently used as string literals with the useFeatureFlag hook (e.g., useFeatureFlag('RfoxFoxEcosystemPage')), not as enums. The hook accepts keyof FeatureFlags which provides type safety through the TypeScript type system rather than requiring an enum. This is the established pattern used throughout the entire codebase.

Applied to files:

• src/state/apis/swapper/swapperApi.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Install and Cache

🔇 Additional comments (2)

src/state/apis/swapper/swapperApi.ts (1)

21-21: LGTM! Timeout increase addresses quote fetching issues.

Doubling the bulk fetch timeout from 5s to 10s provides adequate headroom for the full quote flow (rate fetching plus gas estimation) and directly addresses the timeout errors reported in issue #11072.

src/components/MultiHopTrade/hooks/useGetTradeQuotes/hooks/useGlobalQuotePolling.ts (1)

16-16: LGTM! Polling interval adjusted proportionally.

The 5-second increase in the refetch interval (20s → 25s) maintains the appropriate rhythm with the doubled timeout and prevents quotes from appearing to refetch too rapidly relative to the longer fetch window.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[kaladinlight]

does what it says!