🐛 Bug Fix for invalid 'showBorder' prop- Closes #32#64
Closed
escottalexander wants to merge 1 commit intoshapeshift:developfrom
Closed
🐛 Bug Fix for invalid 'showBorder' prop- Closes #32#64escottalexander wants to merge 1 commit intoshapeshift:developfrom
escottalexander wants to merge 1 commit intoshapeshift:developfrom
Conversation
Contributor
|
This prop is removed in #44 |
Contributor
|
Closing this pr because it ended up getting fixed in #44 which was merged yesterday. Thanks for contributing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue #32
Description
I removed the
showBorderproperty from the Image element as it is invalid syntax. I verified that nowhere in the application relies on this property in its invalid form or what would be valid as a custom propertyshowborder. I also checked documentation for the Image element and confirmed the property does not exist.Testing