Merged
Conversation
technojak
approved these changes
Sep 2, 2021
Contributor
technojak
left a comment
technojak
left a comment
There was a problem hiding this comment.
lgtm just a nitpick about type defs.
Collaborator
|
why are we not using the modal provider for this? |
Contributor
Author
originally was going to be separated out into a separate package for the provider. I can try but not sure how well it will play with the dynamic memory router though. |
0xdef1cafe
approved these changes
Sep 2, 2021
bootsboogie
approved these changes
Sep 3, 2021
Contributor
bootsboogie
left a comment
bootsboogie
left a comment
There was a problem hiding this comment.
LGTM just had a couple questions
Contributor
Author
|
@bootsboogie please review commit da7ff47 for wallet info changes before i merge |
bootsboogie
added a commit
that referenced
this pull request
Sep 8, 2021
* Add tests for dispatch SET_WALLET_MODAL and SET_IS_CONNECTED * Remove initialized since it is not used * Add more tests for WalletProvider * Add coverage to test runner * Make tests alittle better * dry up a bit * clean up of RawText to text.components (#8) (#56) * clean up of RawText to text.components * Update src/assets/translations/messages-en.json Co-authored-by: 0xdef1cafe <88504456+0xdef1cafe@users.noreply.github.com> * abbreviated variables to full-length * update nativeTest -> nativeTestPhrase Co-authored-by: 0xdef1cafe <88504456+0xdef1cafe@users.noreply.github.com> * add key to pin modal (#57) * Fix broken links for license and welcome prs (#51) * Wallet updates (#44) * wallet updates * fix type on button * lint * set wallet info with wallet * asset provider (#67) * Add tests for dispatch SET_WALLET_MODAL and SET_IS_CONNECTED * Remove initialized since it is not used * Add more tests for WalletProvider * Add coverage to test runner * Make tests alittle better * dry up a bit * Fix broken tests from merge * Write tests for connect function Co-authored-by: 420coupe <35115310+420coupe@users.noreply.github.com> Co-authored-by: 0xdef1cafe <88504456+0xdef1cafe@users.noreply.github.com> Co-authored-by: duv <29046942+unclerom@users.noreply.github.com> Co-authored-by: Itgel Ganbold <13912728+iganbold@users.noreply.github.com> Co-authored-by: Sean Luther <elmutt@gmail.com>
0xdef1cafe
pushed a commit
that referenced
this pull request
May 15, 2023
chore: DE translations update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notice
Before submitting a pull request, please make sure you have answered the following:
Pull Request Type
Issue (if applicable)
closes #59
closes #14
Description
Refactor some of the wallet config and fix connected wallet icons
Please describe your changes
Testing
Please outline all testing steps
yarnto install new depsScreenshots (if applicable)