Skip to content

doc: Disambiguate modification time vs timestamp#1704

Merged
tavianator merged 1 commit intosharkdp:masterfrom
vp-elitnet:changed_opt_doc_fix
Apr 2, 2025
Merged

doc: Disambiguate modification time vs timestamp#1704
tavianator merged 1 commit intosharkdp:masterfrom
vp-elitnet:changed_opt_doc_fix

Conversation

@vp-elitnet
Copy link
Copy Markdown
Contributor

Description of --changed-within has the following statement.

Files with modification times greater than the argument will be returned.

At least for me the natural interpretation of "modification time" is relative, e.g. 2 weeks ago, 24 hours ago, etc. Using this interpretation the statement above is opposite of the actual behaviour: modification time greater than (i.e. more than) 24 hour would match files older than the argument, not newer.

I think the statement intended to say "modification timestamps greater than", which would make it unambiguous, i.e. prevent the incorrect interpretation. Fixed descriptions of both --changed-within and --changed-before accordingly.

@tavianator tavianator merged commit edafedb into sharkdp:master Apr 2, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants