doc: Disambiguate modification time vs timestamp#1704
Merged
tavianator merged 1 commit intosharkdp:masterfrom Apr 2, 2025
vp-elitnet:changed_opt_doc_fix
Merged
doc: Disambiguate modification time vs timestamp#1704tavianator merged 1 commit intosharkdp:masterfrom vp-elitnet:changed_opt_doc_fix
tavianator merged 1 commit intosharkdp:masterfrom
vp-elitnet:changed_opt_doc_fix
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of
--changed-withinhas the following statement.At least for me the natural interpretation of "modification time" is relative, e.g. 2 weeks ago, 24 hours ago, etc. Using this interpretation the statement above is opposite of the actual behaviour: modification time greater than (i.e. more than) 24 hour would match files older than the argument, not newer.
I think the statement intended to say "modification timestamps greater than", which would make it unambiguous, i.e. prevent the incorrect interpretation. Fixed descriptions of both
--changed-withinand--changed-beforeaccordingly.