Update etcetera from 0.9 to 0.10 #1711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks! I PR'd the clippy fix as #1712, we can rebase this once that's merged |
tavianator
force-pushed
the
etcetera-0.10
branch
from
9d3690a to
7cc8f35
Compare
tavianator
reviewed
Apr 29, 2025
Cargo.toml
Outdated
| # Temporarily pin home to keep the MSRV of etcetera from increasing to 1.81.0. | ||
| # This direct dependency can be removed after our MSRV is at least 1.81.0. | ||
| # https://github.com/lunacookies/etcetera/releases/tag/v0.10.0 | ||
| home = "<0.5.11" |
Collaborator
There was a problem hiding this comment.
This doesn't really work as desired. If I run cargo update I get a duplicated home dependency, and the MSRV is still not respected:
├── etcetera v0.10.0
│ ├── cfg-if v1.0.0
│ └── home v0.5.11
├── home v0.4.2
- Pin home to <0.5.11 to avoid MSRV problems
tavianator
force-pushed
the
etcetera-0.10
branch
from
7cc8f35 to
ec81815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin
hometo<0.5.11to avoid MSRV problems. As described in https://github.com/lunacookies/etcetera/releases/tag/v0.10.0. This keeps the MSRV at 1.70.0 (less thanfd’s 1.77.2), rather than increasing it to 1.81.0 foretcetera0.10.