Depend on jemallocator as tikv-jemallocator, and update it to 0.6#1722
Merged
tmccombs merged 2 commits intosharkdp:masterfrom May 15, 2025
Merged
Depend on jemallocator as tikv-jemallocator, and update it to 0.6#1722tmccombs merged 2 commits intosharkdp:masterfrom
tmccombs merged 2 commits intosharkdp:masterfrom
Conversation
Upstream writes: “The project is also published as jemallocator for historical reasons. The two crates are the same except names. For new projects, it's recommended to use tikv-xxx versions instead.”
tmccombs
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, this PR depends on
jemallocatorusing the nametikv-jemallocator. These are the same project; upstream writes:While
fdis not a new project, there’s no reason not to migrate to the newer name.Next, this PR updates
tikv-jemallocatorfrom 0.5.4 to 0.6.0; the changelog for that is here. No code changes were required for the update.As a follow-up, you might consider investigating whether jemalloc can be re-enabled on MacOS:
fd/Cargo.toml
Lines 69 to 71 in efe499a