fix: correct subject-digest format for attest-build-provenance#1910
Closed
ravshansbox wants to merge 1 commit intosharkdp:masterfrom
Closed
fix: correct subject-digest format for attest-build-provenance#1910ravshansbox wants to merge 1 commit intosharkdp:masterfrom
ravshansbox wants to merge 1 commit intosharkdp:masterfrom
Conversation
Remove extra colon in sha256 digest prefix. The correct format is 'sha256:HEX_DIGEST', not 'sha256::HEX_DIGEST'. This was causing attestation failures for all release builds on all platforms.
Collaborator
|
This isn't enough to fix it. See #1904, which this is kind of a duplicate of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The GitHub Actions workflow fails for all release builds in v10.4.0 at the "Attest artifact" step due to an invalid digest format.
The workflow uses:
This produces a double colon (
sha256::...) which is invalid. The correct format is:Impact
All release builds fail at the attestation step, preventing the creation and publishing of release artifacts (tarballs, .deb packages, etc.) for all platforms.
Root Cause
The bug was introduced in PR #1901 which bumped actions/attest-build-provenance from v3 to v4. The new attestation steps were accidentally written with a double colon instead of a single colon after the
sha256prefix.Fix
This change corrects the digest format in both attestation steps.
Fixes #1909
Related