docs: Add PR Expectations#1967
Merged
tmccombs merged 1 commit intosharkdp:masterfrom Apr 23, 2026
Merged
Conversation
Add expectations for making pull requests to CONTRIBUTING.md My main objective is to try to discourage low-effort AI generated pull requests. But I realized several of the guidelines were actually more general, so made the section as a whole more general.
Collaborator
Author
|
I'd welcome any feedback, or thoughts on what our policy should be. |
sharkdp
approved these changes
Apr 14, 2026
Owner
sharkdp
left a comment
sharkdp
left a comment
There was a problem hiding this comment.
Thank you. This seems like a good start to me.
We recently put this policy in place at my day to day job: https://github.com/astral-sh/.github/blob/main/AI_POLICY.md. One aspect that you might want to include is the "AI should not be used to generate comments when communicating with maintainers" aspect.
tavianator
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add expectations for making pull requests to CONTRIBUTING.md
My main objective is to try to discourage low-effort AI generated pull requests. But I realized several of the guidelines were actually more general, so made the section as a whole more general.