Fix fdfind bash completion symlink in Debian packages#1970
Closed
lawrence3699 wants to merge 1 commit intosharkdp:masterfrom
Closed
Fix fdfind bash completion symlink in Debian packages#1970lawrence3699 wants to merge 1 commit intosharkdp:masterfrom
lawrence3699 wants to merge 1 commit intosharkdp:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Debian packaging issue where the fdfind bash-completion symlink was created with a dangling target, preventing completions from working for the fdfind alias.
Changes:
- Update
scripts/create-deb.shto symlinkfdfindbash completion to./fd(matching the installed completion filename). - Add a corresponding entry to the Unreleased bugfixes section in
CHANGELOG.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/create-deb.sh | Fixes the fdfind bash-completion symlink target to match the installed fd completion file name. |
| CHANGELOG.md | Documents the Debian fdfind bash-completion symlink fix under Unreleased bugfixes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
This was fixed by #1889 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1888.
Before this change,
scripts/create-deb.shinstalled the bash completion file asusr/share/bash-completion/completions/fdbut created thefdfindsymlink as./fd.bash, which leaves a dangling symlink in the Debian package.This updates the bash completion symlink to
./fd, matching the installed file name. The fish and zshfdfindsymlinks already point to their installed completion file names, so this makes the bash packaging consistent with the sibling paths.Validation:
bash -n scripts/create-deb.shgit diff --checkfdfind -> ./fdresolves alongside the existing fish and zsh completion symlinks