fix: sanitize escape sequence injection#1976
Open
curious-rabbit wants to merge 3 commits intosharkdp:masterfrom
Open
fix: sanitize escape sequence injection#1976curious-rabbit wants to merge 3 commits intosharkdp:masterfrom
curious-rabbit wants to merge 3 commits intosharkdp:masterfrom
Conversation
tmccombs
requested changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filenames can contain terminal escape codes (like ESC). fd prints them raw to your terminal, so a file named
innocent\x1b]52;c;...\x1b\.txtsilently rewrites your clipboard. Fix: strip control bytes before writing to a TTY.fd -x rm {/}in a dir with a file named -rf runsrm -rf. Fix: prepend ./ when a path placeholder produces a leading dash.fd -x '{}'lets you use {} as the command to run, not just an argument to one. It's inconsistent with fd -X which rejects this. The patch rejects placeholder in args[0] for both modes.Also added tests to ensure changes don't break this in the future