fix: show path-separator error regardless of directory existence#1978
Closed
avasis-ai wants to merge 1 commit intosharkdp:masterfrom
Closed
fix: show path-separator error regardless of directory existence#1978avasis-ai wants to merge 1 commit intosharkdp:masterfrom
avasis-ai wants to merge 1 commit intosharkdp:masterfrom
Conversation
The error about a pattern containing a path separator was only shown when the pattern happened to be an existing directory. Now it shows consistently for any pattern containing a path separator character.
Collaborator
|
Closing in favor of #1975 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
'pattern contains a path separator'error was only shown when the pattern happened to be an existing directory. This made the behavior inconsistent —fd /showed the error (because/is a directory), butfd nonexistent/pathsilently returned no results.This PR removes the
Path::new(&opts.pattern).is_dir()check so the error is shown consistently for any pattern containing a path separator character.Note: On Windows,
\is both the path separator and a regex escape character, so this fix may produce false positives for patterns like\d. A follow-up could be to only apply this check when the pattern is not a valid regex, but that's a larger change.Closes #1873