fix: apply --exclude globs under each --search-path root#2000
Open
leno23 wants to merge 2 commits into
Open
Conversation
Exclude patterns were built relative to the first search path only, so patterns like `ghi/def` did not exclude matching paths under additional `--search-path` roots. Prefix relative globs with `**/` when multiple search paths are used. Fixes sharkdp#1919 Co-authored-by: Cursor <cursoragent@cursor.com>
The warning test belongs to sharkdp#1650 / sharkdp#1999, not the multi search-path exclude fix. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment was marked as low quality.
This comment was marked as low quality.
Open
1 task
Author
|
@sharkdp Friendly ping when you have a moment — small fix for multi-root |
Collaborator
|
@leno23 You just opened all these pull requests, what's with the "friendly ping" comment 13 minutes later? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When multiple
--search-pathroots are given,--excludepatterns likeghi/defwere only evaluated relative to the first root. Matching paths under other roots were not excluded unless the pattern was written as**/ghi/def.This prefixes relative exclude globs with
**/when more than one search path is configured, so the same pattern applies under every root.Fixes #1919
Test plan
normalize_exclude_pattern_for_multi_roottest_exclude_with_multiple_search_pathscargo test/cargo clippy -- -D warningsMade with Cursor