docs: clarify that -e/--extension matches all entry types#2001
Open
leno23 wants to merge 2 commits into
Open
Conversation
Short help stays minimal; long help and man page explain that extension filtering applies to directories as well unless --type restricts results. Addresses maintainer feedback on sharkdp#1922. Fixes sharkdp#1693 Co-authored-by: Cursor <cursoragent@cursor.com>
leno23
force-pushed
the
docs/extension-help-1693
branch
from
69c10ca to
e60582f
Compare
This comment was marked as low quality.
This comment was marked as low quality.
Scope this branch to -e/--extension only (sharkdp#1693). Full-path help clarifications remain in sharkdp#1997. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
@tmccombs Thanks for the review on #1922 — pushed
CI should stay green. Happy to close this if you prefer updating #1922 instead. |
This was referenced May 16, 2026
This comment was marked as low quality.
This comment was marked as low quality.
tmccombs
requested changes
May 20, 2026
| Filter search results by extension | ||
| .IR ext . | ||
| This option can be used repeatedly to allow for multiple possible file extensions. | ||
| By default, this applies to all entry types. Use \fB\-\-type\fR to restrict |
Collaborator
There was a problem hiding this comment.
I think it would be more clear to say it applies to "both files and directories".
Also, I'd prefer for this to come after teh comment about it being allowed to be used repeatedly.
Same applies to the help text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies documentation for
-e/--extension(#1693): the filter matches any entry whose name ends with the extension, including directories (e.g.clojure.zip/), not only regular files.Follows maintainer feedback on #1922:
-h): minimal — "Filter by extension"--help) andfd.1: note that--typecan restrict entry typesTest plan
cargo clippy -- -D warningsMade with Cursor