[GUI] Split shared theme into resource dictionaries - #669
Merged
Conversation
📦 Build artifacts —
|
| Platform | Download |
|---|---|
| Windows (win-x64) | sharpemu-win-x64-9ae1fea |
| Linux (linux-x64) | sharpemu-linux-x64-9ae1fea |
| macOS (osx-x64) | sharpemu-osx-x64-9ae1fea |
From build run #1428. Downloads require a GitHub login and expire after 90 days.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is the next part after #666 for #606
App.axamlcurrently contains the shared colors, brushes, control theme and all global style selectors in one file. This makes styling changes harder to navigate and reviewThis PR only reorganizes the existing theme definitions. It intentionally does not change the launcher layout, visuals or runtime behavior
Changes
Themes/Tokens.axamlSettingRowcontrol theme intoThemes/Templates/SettingRow.axamlBase.axamlSurfaces.axamlButtons.axamlInputs.axamlConsole.axamlLibrary.axamlApp.axamlto the application theme composition rootTesting
dotnet build SharpEmu.slnx -c Release --no-restoredotnet test SharpEmu.slnx -c Release --no-buildall 717 tests passedChecklist
By submitting this pull request, i confirm that:
CONTRIBUTING.md.N/A.N/A).