[GUI] Update library page layout - #690
Merged
Merged
Conversation
📦 Build artifacts —
|
| Platform | Download |
|---|---|
| Windows (win-x64) | sharpemu-win-x64-9c120d9 |
| Linux (linux-x64) | sharpemu-linux-x64-9c120d9 |
| macOS (osx-x64) | sharpemu-osx-x64-9c120d9 |
From build run #1473. Downloads require a GitHub login and expire after 90 days.
Collaborator
|
I think games should be in square format instead of vertical. Because in vertical format, some parts of the cover are cropped. |
Contributor
Author
Ok i'll work on it rn |
Contributor
Author
|
@par274 just changed cards format. In future i plan to make carousel more awesome |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Part of #606
The current library uses a compact cover grid and passes the selected game information in a separate launch bar. In this PR i port the self-contained library part of the redesign while keeping the broader navigation, settings and application architecture outside its scope
Changes
Testing
dotnet build SharpEmu.slnx -c Release --no-restoredotnet test tests/SharpEmu.Libs.Tests/SharpEmu.Libs.Tests.csproj -c Release --no-buildChecklist
By submitting this pull request, I confirm that:
CONTRIBUTING.md.N/A.N/A).