Skip to content

IT-Vault 2.2.3 — every email signs off properly

Choose a tag to compare

@shatheitguy shatheitguy released this 19 Sep 11:45
· 153 commits to main since this release

Every email now ends the same way, in small type:

—
Northside Sports Club
IT-Vault v2.2.3 · GitHub · Sha The IT Guy

Your organisation's name first, because to whoever opens the mail it is from them. Then, smaller and grey, what sent it: IT-Vault, its version, the project, and Sha The IT Guy linking to shatheitguy.in.

Mail is two documents, so it's two footers. The plain-text part can't size type or hyperlink, so it carries the order and spells both URLs out. The HTML part sets 12px for the organisation over 10px grey for the credit, with a hairline rule above — every style inline and every colour a literal hex, because clients strip <style> blocks and Outlook has no var().

The HTML footer is injected before </body> rather than appended after it: some clients drop what follows the document, and Gmail clips it.

Two things found by looking at it rendered

  • The separator came out as · — the button template declared no charset, and nothing guarantees a client reads the MIME header. The footer now uses &middot; and the template declares utf-8.
  • A brand name containing markup would have injected it, so the footer escapes what it's given.

The version is read from APP_VERSION, never typed — a hand-written version in a footer nobody reads is one that's wrong within a month.

tests/test_email_footer.py holds all of it, including that every one of the nine set_content() sites in app.py appends the footer. Adding a tenth without it is the easy mistake here.

Upgrading

Pull the matching image — this one is server-side. The APK carries no app changes; versions move together by design.