fix(cli): populate backend state before ActivateConnection#136
Merged
shazow merged 1 commit intoshazow:mainfrom Feb 4, 2026
Merged
fix(cli): populate backend state before ActivateConnection#136shazow merged 1 commit intoshazow:mainfrom
shazow merged 1 commit intoshazow:mainfrom
Conversation
`wifitui connect <ssid>` (without a passphrase) calls ActivateConnection directly. On the NetworkManager backend this looks up the connection and access point in maps that are only populated by BuildNetworkList. The CLI path never called BuildNetworkList, so those maps were always empty and the command always failed with "connection not found". Call BuildNetworkList(false) immediately before ActivateConnection in the CLI path. No scan is triggered — only the internal state is populated. The JoinNetwork path is left alone; it creates its own unsaved connection and already handles a missing AccessPoint gracefully.
shazow
approved these changes
Feb 4, 2026
| IsSecure: isSecure, | ||
| IsVisible: true, | ||
| Security: security, | ||
| AutoConnect: false, // Can't autoconnect to a network we don't know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wifitui connect <ssid>(without a passphrase) calls ActivateConnection directly. On the NetworkManager backend this looks up the connection and access point in maps that are only populated by BuildNetworkList. The CLI path never called BuildNetworkList, so those maps were always empty and the command always failed with "connection not found".Call BuildNetworkList(false) immediately before ActivateConnection in the CLI path. No scan is triggered — only the internal state is populated. The JoinNetwork path is left alone; it creates its own unsaved connection and already handles a missing AccessPoint gracefully.