fix(members): exclude archived members from the roster and counts#15
Merged
Conversation
The list endpoint returns archived members, but the Members tab (PeopleScreen) showed them in the roster and counted them, and the Settings member-count stat counted them too. Filter archived out of the People roster + its count, and the Settings member count. Archived members remain viewable in Settings > System > Archived members. (The archive PR filtered the secondary MembersScreen, not the live PeopleScreen Members tab.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Archived members were showing in the Members tab roster and being counted.
Cause: the members list endpoint returns archived members (by design, so historical surfaces can resolve them). The #12 archive work filtered them out of the secondary
MembersScreen, but the live Members tab isPeopleScreen, which only search-filtered, and the Settings stat counted the raw list.Fix:
PeopleScreen: filter archived out of the roster list and its count.SettingsViewModel: count active members only for the "N members" stat.Archived members remain viewable/restorable in Settings > System > Archived members (and the
MembersScreencollapsible section).Compiles clean. Note: member pickers (group membership, switch sheet) may still list archived members from the full list - tracked as a separate follow-up sweep.