Skip to content

feat: add configurable port and switch to IPv4 by default#28

Merged
shekohex merged 4 commits intoshekohex:mainfrom
mr-wuliu:main
Apr 20, 2026
Merged

feat: add configurable port and switch to IPv4 by default#28
shekohex merged 4 commits intoshekohex:mainfrom
mr-wuliu:main

Conversation

@mr-wuliu
Copy link
Copy Markdown
Contributor

  • Add PTY_WEB_PORT env var for fixed port (0 = random)
  • Change default hostname from ::1 (IPv6) to 127.0.0.1 (IPv4)
  • Update README with new environment variable

@shekohex
Copy link
Copy Markdown
Owner

CI is failing after your new changes.

@shekohex
Copy link
Copy Markdown
Owner

shekohex commented Apr 3, 2026

Looks good, but can you rebase your PR?

- Add PTY_WEB_PORT env var for fixed port (0 = random)
- Change default hostname from ::1 (IPv6) to 127.0.0.1 (IPv4)
- Update README with new environment variable
@mr-wuliu
Copy link
Copy Markdown
Contributor Author

mr-wuliu commented Apr 3, 2026

Looks good, but can you rebase your PR?

Thanks! I've rebased the PR.

By the way, I noticed the project prefers using [::1] instead of 127.0.0.1. Is there a specific reason for favoring IPv6 loopback here?

@shekohex
Copy link
Copy Markdown
Owner

shekohex commented Apr 3, 2026

Looks good, but can you rebase your PR?

Thanks! I've rebased the PR.

By the way, I noticed the project prefers using [::1] instead of 127.0.0.1. Is there a specific reason for favoring IPv6 loopback here?

The original author of the Frontend app mentioned this

I'm not sure why we should be changing this again now, but lets ping @MBanucu just in case.

@mr-wuliu
Copy link
Copy Markdown
Contributor Author

mr-wuliu commented Apr 4, 2026

Looks good, but can you rebase your PR?

Thanks! I've rebased the PR.
By the way, I noticed the project prefers using [::1] instead of 127.0.0.1. Is there a specific reason for favoring IPv6 loopback here?

The original author of the Frontend app mentioned this

I'm not sure why we should be changing this again now, but lets ping @MBanucu just in case.

Respecting the original author's preference, I changed the default host back to [::1]. This is still configurable via
PTY_WEB_HOSTNAME for environments that need a different host.

@MBanucu
Copy link
Copy Markdown
Contributor

MBanucu commented Apr 6, 2026

Looks good, but can you rebase your PR?

Thanks! I've rebased the PR.
By the way, I noticed the project prefers using [::1] instead of 127.0.0.1. Is there a specific reason for favoring IPv6 loopback here?

The original author of the Frontend app mentioned this

I'm not sure why we should be changing this again now, but lets ping @MBanucu just in case.

Short answer: IPv6 is modern, it is working and it is future proof. Dual stack is preferred, but I didn't invest any time to set up dual stack. Do as you wish. It's fine.

@shekohex shekohex merged commit 90c0f96 into shekohex:main Apr 20, 2026
7 checks passed
@shekohex
Copy link
Copy Markdown
Owner

Thanks, will be released soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants