ci: group the go modules that ship together - #6871
Merged
Merged
Conversation
group-by: dependency-name gives each dependency its own pull request across the six modules, which is what an unrelated bump deserves. It is wrong for a project shipping several modules: those release together and pin each other, so one pull request per module carries the same edits and only the first can land. caddy was already carved out for exactly this. Name the other three: testcontainers-go with its compose, postgres and redis modules, bun with pgdialect, and the golang.org/x repositories. The catch-all excludes them by hand, because a dependency matching more than one group is not placed in the first match. golang-x keeps applies-to: version-updates where the others drop it. Those modules are not coupled, they only tend to move together, so a crypto or net security fix should still arrive on its own.
|
Claude finished @otavio's task in 1m 8s —— View job Code Review CompleteReviewed 1 file ( A few things I verified in the diff:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
group-by: dependency-namegives each dependency its own pull request across thesix Go modules, which is right for a dependency that moves on its own — and it is
why this config is not simply the one
clouduses.It is wrong for a project shipping several modules. Those release together and pin
each other, so one pull request per module carries the same edits in each and only
the first can land.
caddywas already carved out for exactly this reason; thisnames the other three.
caddy(existing)caddyserver/*,caddy-dns/*testcontainerstestcontainers-go+compose,postgres,redisbunuptrace/bun,uptrace/bun/dialect/pgdialectgolang-xgolang.org/x/crypto,exp,net,sys,timeThe catch-all excludes each by hand, because a dependency matching more than one
group is not placed in the first match — the same caveat already noted on the npm
entry.
golang-xkeepsapplies-to: version-updateswhere the others drop it: thosemodules are not coupled, they only tend to move together, so an
x/cryptoorx/netsecurity fix should still arrive on its own rather than waiting behind anx/expbump.Verification
Resolved the patterns against the 56 direct requirements across
/,/agent,/gateway,/openapi,/serverand/tests:No change to
github-actions,dockerornpm.