Add test case for sed on empty file#904
Merged
nfischer merged 1 commit intoshelljs:masterfrom Nov 13, 2018
wyardley:wyardley-sed-empty-test
Merged
Add test case for sed on empty file#904nfischer merged 1 commit intoshelljs:masterfrom wyardley:wyardley-sed-empty-test
nfischer merged 1 commit intoshelljs:masterfrom
wyardley:wyardley-sed-empty-test
Conversation
As discussed in #900, when sed runs on an empty file, make sure we don't add a trailing newline, and still exit 0
Contributor
Author
|
Not sure about the Appveyor failure - saw it on a few other PRs. force-pushing w/ a comment change didn't seem to fix it tho. Seems unrelated |
Member
|
Yeah, appveyor has been having problems since #896. |
Codecov Report
@@ Coverage Diff @@
## master #904 +/- ##
=======================================
Coverage 97.32% 97.32%
=======================================
Files 34 34
Lines 1269 1269
=======================================
Hits 1235 1235
Misses 34 34Continue to review full report at Codecov.
|
nfischer
approved these changes
Nov 13, 2018
This was referenced Nov 29, 2019
This was referenced Mar 24, 2020
This was referenced Apr 24, 2020
This was referenced Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed as an aside in #900, add test case with an empty file.