Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for sed on empty file #904

Merged
merged 1 commit into from Nov 13, 2018
Merged

Add test case for sed on empty file #904

merged 1 commit into from Nov 13, 2018

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Nov 10, 2018

As discussed as an aside in #900, add test case with an empty file.

As discussed in #900, when sed runs on an empty file, make sure we don't add a
trailing newline, and still exit 0
@wyardley
Copy link
Contributor Author

@wyardley wyardley commented Nov 10, 2018

Not sure about the Appveyor failure - saw it on a few other PRs. force-pushing w/ a comment change didn't seem to fix it tho. Seems unrelated

@nfischer
Copy link
Member

@nfischer nfischer commented Nov 13, 2018

Yeah, appveyor has been having problems since #896.

@codecov-io
Copy link

@codecov-io codecov-io commented Nov 13, 2018

Codecov Report

Merging #904 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #904   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files          34       34           
  Lines        1269     1269           
=======================================
  Hits         1235     1235           
  Misses         34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b3c7b1...0f2df9f. Read the comment docs.

@nfischer nfischer merged commit db317bf into shelljs:master Nov 13, 2018
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants