-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test case for sed on empty file #904
Conversation
As discussed in #900, when sed runs on an empty file, make sure we don't add a trailing newline, and still exit 0
Not sure about the Appveyor failure - saw it on a few other PRs. force-pushing w/ a comment change didn't seem to fix it tho. Seems unrelated |
Yeah, appveyor has been having problems since #896. |
Codecov Report
@@ Coverage Diff @@
## master #904 +/- ##
=======================================
Coverage 97.32% 97.32%
=======================================
Files 34 34
Lines 1269 1269
=======================================
Hits 1235 1235
Misses 34 34 Continue to review full report at Codecov.
|
As discussed as an aside in #900, add test case with an empty file.