Lift the four-digit series ceiling at 0099 - #199
Merged
Conversation
The series globs matched 00*.patch, so a patch numbered 0100 or above was applied by nothing and audited by nothing — no error, just a runtime missing the fix. The Wine series is at 0097. Match [0-9][0-9][0-9][0-9]-*.patch instead, in the apply loop, the stack stamp and the freeze. Zero-padded four-digit names sort the same lexically as numerically, so apply order is unchanged. The unlisted-patch check now lists every .patch on disk rather than the ones the series glob matches, so a file that falls outside the numbering scheme is reported instead of passing as absent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The series globs matched
00*.patch, so a patch numbered 0100 or above was applied by nothing and audited by nothing — no error, just a runtime missing the fix. The Wine series is at 0097, leaving 0098 and 0099.Match
[0-9][0-9][0-9][0-9]-*.patchinstead, in the apply loop, the stack stamp and the freeze. Zero-padded four-digit names sort the same lexically as numerically, so apply order is unchanged — verified across the 0097→0100 boundary.The unlisted-patch check now lists every
.patchon disk rather than the ones the series glob matches, so a file outside the numbering scheme is reported instead of passing as absent.Verified with a synthetic
0100-patch present: the old glob saw 95 Wine patches, the new one 96, and the audit reports it asunlisted patches present.