Skip to content

Dogfood variable glyph editing flow#140

Merged
kostyafarber merged 2 commits into
mainfrom
codex/variable-editing-dogfood
Jul 9, 2026
Merged

Dogfood variable glyph editing flow#140
kostyafarber merged 2 commits into
mainfrom
codex/variable-editing-dogfood

Conversation

@kostyafarber

Copy link
Copy Markdown
Collaborator

Summary

  • Adds app-shell to renderer command routing and a Glyph menu action for reversing the selected contour.
  • Makes renderer clipboard access async through preload/main IPC and updates keyboard routing to await copy, cut, and paste.
  • Keeps the renderer workspace alive across Fast Refresh by splitting context objects from providers and exposing window.shift from a stable runtime.
  • Adds lazy source-layer materialization for the opened glyph, backed by a native cloneGlyphLayer intent with fresh internal IDs.
  • Adds shift-cli inspect --view layers and layer counts in inspect JSON for debugging .shift packages.

Validation

  • cargo fmt
  • pnpm format:check
  • pnpm typecheck
  • pnpm lint:check
  • cargo test -p shift-bridge -p shift-font -p shift-cli
  • pnpm --filter @shift/desktop test src/renderer/src/lib/editor/Editor.test.ts src/renderer/src/lib/clipboard/Clipboard.test.ts src/renderer/src/lib/keyboard/KeyboardRouter.test.ts
  • pre-commit hook: cargo check/fmt/clippy/test, oxfmt, oxlint, tsgo typecheck, deadcode, vitest

Comment thread apps/desktop/src/renderer/src/lib/editor/Editor.ts Outdated
Comment thread apps/desktop/src/renderer/src/lib/editor/Editor.ts Outdated
this.scene.updateNode({ id: node.id, sourceId });
}

#setActiveSource(sourceId: SourceId, location: Location): void {

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be private?

@kostyafarber kostyafarber merged commit f03c5ad into main Jul 9, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant