Rotate ansible-vault password to a stronger key - #31
Merged
Conversation
Replace the weak vault password with a randomly generated 64-character base64-encoded key. The vault-pass file in shiftstack-tools and the shiftstack-client container image have been updated accordingly. OSPRH-32937 Change-Id: I4d86640a7e92c46492dd47513f481870d7a11902 Signed-off-by: Itay Matza <imatza@redhat.com>
imatza-rh
requested review from
chenwng,
dlaw4608,
ekuris-redhat,
eshulman2,
gryf,
mandre,
stephenfin,
tusharjadhav3302 and
winiciusallan
as code owners
August 5, 2026 14:35
Contributor
|
/lgtm |
dlaw4608
approved these changes
Aug 5, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlaw4608 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the vault password with a stronger randomly generated key.
Changes:
configs/secret.yamlrekeyed with new passwordCompanion changes:
quay.io/shiftstack-qe/shiftstack-client:latestrebuilt and pushedJira: OSPRH-32937