fix(doctor): CLOUDFLARE_API_TOKEN のチェックを Environment secret 側に移す#190
Merged
Conversation
setup.md M2 の方針 (repo level に置かず staging/production の Environment secret に 権限を絞った token を分離) と doctor の必須チェックが不整合で、方針どおりの構成が fail 判定されていた。repo level の必須リストから外して各 Environment の必須に移し、 repo level に残存する場合は warn で分離を促す。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🚀 Preview Deployment
Deployed from commit 2840548 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
npm run doctor -- --maintainerが repo secretCLOUDFLARE_API_TOKENを必須扱いしていたが、docs/setup.md M2 の方針は「repo level に置かず Environment secret に分離」(preview/staging に本番デプロイ権限 token を露出させないため) であり、方針どおりの構成が fail 判定される不整合があった (タグ式 GitHub Flow 移行時の検証で発見)。変更
REQUIRED_REPO_SECRETSからCLOUDFLARE_API_TOKENを除外 (ACCOUNT_ID / PROJECT_NAME のみ)REQUIRED_ENV_SECRETSにCLOUDFLARE_API_TOKENを追加 (staging / production 各 Environment で検査)CLOUDFLARE_API_TOKENが残存する場合は warn で分離を案内検証
現構成 (Environment secret 分離済み) で
doctor --maintainerの GitHub セクションが全 ✓ になることを確認済み。🤖 Generated with Claude Code