fix(seo): link orphan pages from nav/footer, drop dead URLs from sitemap#35
Merged
Conversation
Ahrefs Site Audit reported 6 orphan pages on bones.sh (sitemap URLs with no incoming internal links). Root cause: the global footer only linked Home, Sign in, and legal pages, so /about, /bones/cli-www, /changelog, /cli, /contact, /faq, and /features were unreachable from any internal link. The sitemap also advertised /docs (planned route, no page) and /v1 (CLI logger API endpoint), both 404s. - Footer: link Features, CLI, CLI Demo, Changelog, About, FAQ, Contact, EULA, and Legal; point the Shipkit link at shipkit.io instead of a duplicate self-referencing bones.sh link - Header nav: add Features, CLI, and FAQ - Sitemap: exclude /docs and /v1 - Add regression test asserting every sitemap URL is linked from the site chrome and dead routes stay out of the sitemap; install the missing vitest/testing-library dev deps the repo's test scripts and vitest.config.ts already referenced Verified by crawling the production build locally: sitemap 14 -> 12 URLs, orphans 9 -> 0 (every sitemap URL now has 13 incoming links). LAC-2783 Co-Authored-By: Paperclip <noreply@paperclip.ing>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Failed to generate code suggestions for PR |
Vercel installs with pnpm --frozen-lockfile; the new vitest/testing-library dev deps were only in bun.lock, failing the preview build. Co-Authored-By: Paperclip <noreply@paperclip.ing>
…t commit status The smoke test passed but the final "Report check result" step 403'd (Resource not accessible by integration) because the workflow token had no statuses:write permission, marking the whole check as failed. Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes LAC-2783 — Ahrefs Site Audit (project "Bones") reports 6 orphan pages on bones.sh, stable across weekly crawls (Jun 27, Jul 4, Jul 11 2026).
Root cause: the global footer only linked Home, Sign in (plus external Shipkit links) and the legal pages. Every other page —
/about,/bones/cli-www,/changelog,/cli,/contact,/faq,/features— had zero incoming internal links. The sitemap also advertised two dead URLs:/docs(planned route with no page) and/v1(the CLI logger API endpoint), both returning 404.Note: a previous fix for the sitemap 404s (LAC-2431) landed in
lacymorrow/bones-www, but bones.sh actually deploys from this repo (shipkit-io/bones, Vercel projectbones), so it never reached production.Changes
src/components/footers/footer.tsx): link Features, CLI, CLI Demo, Changelog, About, FAQ, Contact, EULA, and Legal. Also points the "Shipkit" link atshipkit.io— it previously duplicated the self-referencingbones.shlink.src/config/navigation.ts): add Features, CLI, FAQ.src/app/sitemap.ts): exclude/docsand/v1(no pages exist;/v1is an API endpoint).tests/unit/seo-internal-links.test.ts): asserts every sitemap URL is linked from the header nav or footer, and that dead routes stay out of the sitemap.vitest,jsdom,@vitejs/plugin-react,vite-tsconfig-paths,@testing-library/*— the repo'stestscripts andvitest.config.tsalready referenced them but they were never installed.Acceptance criteria / verification
Per the ticket, re-ran a local crawl after the fix (production build via
next start, BFS over all internal<a href>from/, diffed against/sitemap.xml):bun run testpasses (3 tests). Ahrefs orphan count should drop to 0 on the next weekly crawl after deploy.