fix(seo): serve OG image from bones.sh; document canonical repo (LAC-2792)#37
Merged
Merged
Conversation
…2792) - ogImage pointed at https://shipkit.io/og so social shares of bones.sh showed ShipKit branding. The bones-www fix for this (ed542128) never shipped because bones-www stopped deploying to bones.sh. Point it at the site's own working /og route, with a regression test. - Document in CLAUDE.md and README that THIS repo (shipkit-io/bones) is canonical for bones.sh production (Vercel project 'bones'), and that lacymorrow/bones-www is dead for bones.sh.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Failed to generate code suggestions for PR |
Contributor
Author
|
Review status: the AI Code Reviewer job posted "Failed to generate code suggestions for PR" — the bot errored, no feedback produced. Gemini review-pr was skipped, CodeQL + smoke-test pass. Proceeding once the Lighthouse audit check completes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paperclip issue
LAC-2792 — bones.sh repo/deploy mapping: bones-www changes never reach prod.
Summary
siteConfig.ogImagepointed athttps://shipkit.io/og, so social shares of bones.sh showed ShipKit's OG image. bones-www fixed this in Mar 2026 (ed542128) but that repo stopped deploying to bones.sh, so the fix never shipped. Now points at bones.sh's own working/ogroute.tests/unit/seo-og-image.test.tsasserts the OG image origin matches the site origin (fails on the bug, passes after).bones, branchmain) and thatlacymorrow/bones-wwwis dead for bones.sh.Testing
bunx vitest run tests/unit/→ 2 files, 4 tests passed (new test verified red before the fix).https://bones.sh/ogreturns200 image/png.Acceptance criteria (LAC-2792)