fix: shipthis game ios app addTester was not adding the current user as a tester#190
Merged
Conversation
madebydavid
marked this pull request as ready for review
April 16, 2026 15:06
Member
Author
|
I have tested this - but will get an automated review - the change is minimal |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the shipthis game ios app addTester workflow to more reliably add a tester (including --self) by updating the underlying Apple utilities dependency and improving how TestFlight beta groups are selected/created.
Changes:
- Bumps
@expo/apple-utilsto a newer version. - Changes the default internal TestFlight group name and adds a
--testGroupNameflag. - Adds extra command output around group creation and tester assignment.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
src/commands/game/ios/app/addTester.tsx |
Adds configurable test group naming and extra output during group creation / tester assignment. |
package.json |
Updates @expo/apple-utils dependency version. |
package-lock.json |
Locks updated @expo/apple-utils resolved version/integrity. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tGroupName default Agent-Logs-Url: https://github.com/shipth-is/cli/sessions/f8376578-8fe6-4e5b-8693-577d0291259b Co-authored-by: madebydavid <5401249+madebydavid@users.noreply.github.com>
Agent-Logs-Url: https://github.com/shipth-is/cli/sessions/f8376578-8fe6-4e5b-8693-577d0291259b Co-authored-by: madebydavid <5401249+madebydavid@users.noreply.github.com>
madebydavid
changed the title
shipthis game ios app addTester was not adding myself as a testershipthis game ios app addTester was not adding the current user as a tester
madebydavid
deleted the
189-bug-wizard-did-not-add-self-as-tester---and-running-shipthis-game-ios-app-addtester---self-also-not-effective
branch
April 16, 2026 15:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to resolve #189
What's changed: