fix: EventEmiiter warning when running shipthis game wizard ios#198
Merged
madebydavid merged 1 commit intoMay 2, 2026
Conversation
… with maxListeners
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the MaxListenersExceededWarning observed after running shipthis game wizard ios (notably in flows that execute many subcommands in-process via this.config.runCommand), by eliminating per-command signal listener registration in the base command lifecycle.
Changes:
- Removed
process.on('SIGINT'| 'SIGTERM')handlers fromBaseCommand.init()to prevent accumulated listeners across chained command runs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
madebydavid
deleted the
191-bug-eventemitter-warning-after-running-shipthis-game-wizard-ios
branch
May 2, 2026 11:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to resolve #191
What's changed
Testing
I have tested the following:
shipthis game wizard iosshipthis game shipshipthis game ship --platform ios --followshipthis game wizard androidThese listeners were added to solve a problem, but we are not certain which problem. All of these related commands are working correctly. I have been able to run them successfully and run them and press Ctrl+C and they exit correctly.