use image proxy for images#5
Merged
vitek-rostislav merged 3 commits intomainfrom Dec 5, 2023
Merged
Conversation
- the legacy URLs might contain image size name and additional size index - these are dropped now - e.g. /content/images/product/web/original/0--hello-kitty_1.jpg is redirected to /content/images/product/web/hello-kitty_1.jpg - finally, /content/images/product/web/1.jpg file is served from the webserver
grossmannmartin
approved these changes
Nov 30, 2023
vitek-rostislav
force-pushed
the
vitek-rostislav-patch-1
branch
from
40b57a9 to
badc4e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image resizing is not handled by Shopsys Framework anymore, an image proxy is used instead, see shopsys/shopsys#2924