fix: allow nested DAL ID filters - #44
Merged
Merged
Conversation
Jonas Elfering (keulinho)
requested review from
Martin Bens (SpiGAndromeda),
Michael Telgmann (mitelg) and
Soner (shyim)
August 17, 2026 08:28
Jonas Elfering (keulinho)
marked this pull request as ready for review
August 17, 2026 08:28
Soner (shyim)
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid false positives when an ID equality filter is nested in a compound DAL filter.
Details
Criteria::addFilter()calls instead of every filter instantiationEqualsFilterorEqualsAnyFilteronid, which can be replaced withCriteria::setIds()MultiFilter,NotFilter, andOrFilternestingValidation
vendor/bin/phpunit tests/Rule/NoDALFilterByIDTest.phpPHP_CS_FIXER_IGNORE_ENV=1 vendor/bin/php-cs-fixer fix --dry-run --diff