Update Dockerfile.base to use ghcr.io/shopware/docker-dev as base image#1174
Merged
Conversation
- Switch to ghcr.io/shopware/docker-dev:php${PHP_VERSION}-node${NODE_VERSION}-caddy as base image
- Make PHP and Node versions configurable via build args
- Add bun installation from oven/bun:alpine
- Make PHP memory_limit configurable via PHP_MEMORY_LIMIT env var
- Switch to root user for package installation, then back to www-data
- Simplify Dockerfile by leveraging pre-installed packages in base image
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1174 +/- ##
=======================================
Coverage 47.35% 47.35%
=======================================
Files 231 231
Lines 16512 16512
=======================================
Hits 7819 7819
Misses 8693 8693
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
Dockerfile.baseto useghcr.io/shopware/docker-dev:php${PHP_VERSION}-node${NODE_VERSION}-caddyas the base image instead of building from scratch.Changes
ghcr.io/shopware/docker-devas base imagePHP_VERSION,NODE_VERSION)oven/bun:alpinememory_limitconfigurable viaPHP_MEMORY_LIMITenvironment variableBenefits
Testing
PHP_MEMORY_LIMIT=1GBreaking Changes
None - The image should be backward compatible. The build pipeline will continue to work with the matrix strategy for multiple PHP versions.