Update cms-element-product-description-reviews.html.twig - #6487
Conversation
Fix twig filter ordering in product-detail-tab-preview.
|
|
Fix for #4657 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #6487 +/- ##
==========================================
+ Coverage 55.04% 55.20% +0.16%
==========================================
Files 4777 4800 +23
Lines 161995 163386 +1391
Branches 8905 8929 +24
==========================================
+ Hits 89167 90198 +1031
- Misses 70206 70559 +353
- Partials 2622 2629 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
could you also check the suggestion Marc (@cramytech) above if it also works for you? |
…product-description-reviews.html.twig Co-authored-by: Vin Le <levienthuong@gmail.com>
|
Hi Marc (@cramytech) sorry for the delay, we overlooked this PR. I was actually no longer able to reproduce this in current trunk. When I have umlauts in my product description as entities, they are displayed correctly in mobile preview. Because it gets converted into UTF-8 umlauts during "save" in the admin. But I think we can still merge this together with the suggestion from Vin Le (@vienthuong) to get rid of the redundant sanitize. Somehow I can also not reproduce it anymore when I enter umlauts directly to the product description in the database. I still have the real character in the storefront (in the HTML source code). |
Fix twig filter ordering in product-detail-tab-preview.
1. Why is this change necessary?
2. What does this change do, exactly?
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist