Skip to content

Update cms-element-product-description-reviews.html.twig - #6487

Merged
Vin Le (vienthuong) merged 4 commits into
shopware:trunkfrom
cramytech:trunk
Nov 3, 2025
Merged

Update cms-element-product-description-reviews.html.twig#6487
Vin Le (vienthuong) merged 4 commits into
shopware:trunkfrom
cramytech:trunk

Conversation

@cramytech

Copy link
Copy Markdown
Contributor

Fix twig filter ordering in product-detail-tab-preview.

1. Why is this change necessary?

2. What does this change do, exactly?

3. Describe each step to reproduce the issue or behaviour.

4. Please link to the relevant issues (if any).

5. Checklist

  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfill them.

Fix twig filter ordering in product-detail-tab-preview.
@github-actions

Copy link
Copy Markdown
Contributor
Warnings
⚠️ The Pull Request doesn't contain any changelog file

@cramytech

Copy link
Copy Markdown
Contributor Author

Fix for #4657

@codecov

codecov Bot commented Jan 29, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.20%. Comparing base (e343970) to head (b0990b1).
⚠️ Report is 213 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk    #6487      +/-   ##
==========================================
+ Coverage   55.04%   55.20%   +0.16%     
==========================================
  Files        4777     4800      +23     
  Lines      161995   163386    +1391     
  Branches     8905     8929      +24     
==========================================
+ Hits        89167    90198    +1031     
- Misses      70206    70559     +353     
- Partials     2622     2629       +7     
Flag Coverage Δ
jest-admin 61.05% <ø> (+0.06%) ⬆️
jest-storefront 69.75% <ø> (+0.13%) ⬆️
phpunit-migration 48.63% <ø> (+0.68%) ⬆️
phpunit-unit 48.49% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mitelg Michael Telgmann (mitelg) added domain/framework Responsible for the framework-level code includes core, administration, storefront, and frontends domain/inventory Responsible for managing products and everything product-related and removed component/storefront domain/framework Responsible for the framework-level code includes core, administration, storefront, and frontends labels Apr 25, 2025
@vienthuong

Copy link
Copy Markdown
Contributor

could you also check the suggestion Marc (@cramytech) above if it also works for you?

@cramytech
Marc (cramytech) requested a review from a team July 19, 2025 10:06
@vienthuong
Vin Le (vienthuong) requested a review from a team July 21, 2025 03:25
…product-description-reviews.html.twig

Co-authored-by: Vin Le <levienthuong@gmail.com>
@tobiasberge

Copy link
Copy Markdown
Contributor

Hi Marc (@cramytech) sorry for the delay, we overlooked this PR.

I was actually no longer able to reproduce this in current trunk. When I have umlauts in my product description as entities, they are displayed correctly in mobile preview. Because it gets converted into UTF-8 umlauts during "save" in the admin.

But I think we can still merge this together with the suggestion from Vin Le (@vienthuong) to get rid of the redundant sanitize. Somehow I can also not reproduce it anymore when I enter umlauts directly to the product description in the database. I still have the real character in the storefront (in the HTML source code).

@vienthuong
Vin Le (vienthuong) added this pull request to the merge queue Nov 3, 2025
Merged via the queue into shopware:trunk with commit 132f59f Nov 3, 2025
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/inventory Responsible for managing products and everything product-related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Special chars in product description (HTML Entities) - wrong displayd in product-detail-tab-preview

8 participants