docs/BillieJean: drop the grace_ticks workaround, now unneeded - #1038
Merged
Conversation
A due-or-overdue one-off ticks= plays immediately as of #1036, so the BillieJeanScheduled example no longer has to aim 8 ticks into the future to keep the first notes of a cycle from being thrown away. Removes grace_ticks from the sketch and from the walkthrough's copy of it (the doc had dropped the use but kept the now-unused declaration and its now-false comment), and makes amy_ticks_per_tick 24.0f in both -- they had drifted apart, and an unsuffixed double literal pulls in software double emulation on 32-bit targets. Also corrects docs/synth.md, which still told readers an absolute tick in the past would be ignored. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1036.
A due-or-overdue one-off
ticks=now plays immediately instead of being dropped, so theBillieJeanScheduledexample no longer needs to aimgrace_ticksinto the future to stop the first notes of a cycle being thrown away.grace_ticksfrom the sketch and from the walkthrough's copy of it. The doc had already dropped the use but kept the now-unused declaration and its now-false comment (// Scheduled events in the past are ignored).amy_ticks_per_tick24.0fin both. They had drifted apart (24.0fin the doc,24.0in the.ino), and an unsuffixed double literal pulls in software double emulation on 32-bit targets — the same reasonsequencer_recompute()keeps its arithmetic single-precision.docs/synth.md, which still told readers "If an absolutetickis in the past, AMY will ignore it."The doc's code block and the
.inoare now byte-identical throughschedule_notes(), verified programmatically.make test: 122 tests pass.🤖 Generated with Claude Code