daisy: stagger midi_polyphony in real time; local libDaisy paths [skip release] - #1042
Merged
Conversation
…p release] midi_polyphony() lost its note spacing when the MIDI time argument went away in #1040 -- a MIDI message plays when it arrives, so all 15 notes landed at once. Space them with System::DelayMs(1000) instead, which is what the old time argument was pretending to do. Also points LIBDAISY_DIR/DAISYSP_DIR at ~/github/electro-smith. Like the ~/Desktop/DaisyExamples paths they replace, these are wherever the person building happens to keep libDaisy -- there is no in-tree default to use. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small Daisy-only changes. Nothing here is compiled by any CI target — the Daisy port builds out of tree against a local libDaisy — hence
[skip release].midi_polyphony()gets its stagger back#1040 removed the
timeargument fromamy_event_midi_message_received(), because a live MIDI message carries no scheduling time — it plays when it arrives. That leftmidi_polyphony()firing all 15 notes at once, where it used to space them a second apart.Restores the spacing with
System::DelayMs(1000), which does in real time what the old argument only appeared to do.Local libDaisy paths
Points
LIBDAISY_DIR/DAISYSP_DIRat~/github/electro-smith/{libDaisy,DaisySP}.Worth being explicit: these are just as machine-specific as the
~/Desktop/DaisyExamples/...paths they replace. There's no in-tree default — whoever builds the Daisy port edits these to wherever they keep libDaisy.🤖 Generated with Claude Code