Use intptr_t instead of int64_t for void* state casts - #571
Merged
Conversation
The yield_synth_events and yield_synth_commands functions use void* as an opaque integer state. On 32-bit targets (ESP32), casting between void* and int64_t triggers -Wpointer-to-int-cast warnings since the sizes differ. intptr_t is guaranteed to match pointer width on all platforms. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
int64_twithintptr_tin 5 casts betweenvoid*and integer inpatches.c-Wpointer-to-int-castwarnings on 32-bit ESP32 targets whereint64_t(8 bytes) !=void*(4 bytes)intptr_tis guaranteed to match pointer width on all platformsTest plan
make testpasses (72 tests)🤖 Generated with Claude Code