Fix release: drop obsolete amy.aw.js/amy.ww.js from web build#775
Merged
Conversation
Releases have failed at the Rebuild web assets step since #773. make deploy-web ran "cp build/amy.wasm build/amy.aw.js build/amy.ww.js docs/", but emscripten 4.0.x inlines the AudioWorklet/WasmWorker glue into amy.js and no longer emits separate amy.aw.js / amy.ww.js files, so the cp failed and the release aborted before tagging (no release has cut since #773). Those files were vestigial: both old and new amy.js load the worklet from themselves via audioWorklet.addModule(locateFile("amy.js")), never fetching amy.aw.js / amy.ww.js by name. Drop them from the whole pipeline (Makefile deploy-web, release.yml rebuild comment + bump git add, godot-addon.yml package copy, godot/install.gd and setup_godot.sh web file lists/copies, docs/godot.md, CLAUDE.md) and delete docs/amy.aw.js / docs/amy.ww.js. make deploy-web now succeeds; the unblocked release will refresh docs/amy.js + amy.wasm. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
pull Bot
pushed a commit
to manmuqingshan/tulipcc
that referenced
this pull request
Jun 29, 2026
amy dropped the separate amy.aw.js/amy.ww.js from its web build (shorepine/amy#775): emscripten >=4 inlines the AudioWorklet/WasmWorker glue into amy.js, which never references a separate .aw.js. tulip/web/build.sh still hard-copied amy/docs/amy.aw.js, so under `set -e` the whole web preview build aborts with "cp: cannot stat '../../amy/docs/amy.aw.js'" once a newer amy is pinned (e.g. the amy-pin PRs the tulipcc auto-pin workflow opens). Guard the copy with `[ -f ]` so it's copied only when an older pinned amy still ships it, mirroring amyboardweb/dev.py which already guards the same copy with os.path.exists(). No runtime effect: amy.js loads the worklet inline either way. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
Releases have failed at the "Rebuild web assets" step on every merge since #773 — so no release has been cut since.
make deploy-webran:emscripten 4.0.x inlines the AudioWorklet / WasmWorker glue into
amy.jsand no longer emits separateamy.aw.js/amy.ww.jsfiles (verified locally with the pinned emsdk 4.0.22 —make webproduces onlyamy.js+amy.wasm). So thecpfailed and the release aborted before tagging.Why removing them is safe
Those files were never loaded at runtime. Both the old and new
amy.jsbootstrap the worklet from themselves:Neither references
amy.aw.js/amy.ww.jsby name. They were emitted by a long-ago emscripten and left behind indocs/and the copy scripts — pure dead weight.The fix
Drop them from the entire pipeline and delete the files:
Makefile—deploy-webnowcp build/amy.wasm docs/onlyrelease.yml— removed from the rebuild comment and the bumpgit addgodot-addon.yml— removed the twocp docs/amy.aw.js|ww.jslines from the package step (these would now fail, since the files are gone)godot/install.gd+setup_godot.sh— removed from the web-file lists and copies (both copies)docs/godot.md,CLAUDE.md— doc references removeddocs/amy.aw.js,docs/amy.ww.jsVerified
make deploy-webnow succeeds.bash -n setup_godot.shand YAML validation pass.docs/amy.js/docs/amy.wasmare intentionally left as-is (the committed build already works standalone) — the now-unblocked release will rebuild them from source, which also picks up thebuskwarg in the JS API.🤖 Generated with Claude Code