Execute pending resets before loading Memory PCM#962
Merged
Conversation
Collaborator
|
Thanks! |
Collaborator
⛓️ tulipcc integration PR openedThis merge was pinned into tulipcc for full-system CI: shorepine/tulipcc#1228 Test it there and merge that PR to move tulipcc onto this AMY. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestLoadSamplegolden test to coveramy.reset()immediately followed by
amy.load_sample()Problem
amy.reset()queuesRESET_ALL_OSCS, while Memory PCM allocation performedby
load_sample()happens immediately when the transfer header is parsed.This allows the following ordering:
RESET_ALL_OSCSis queuedamy_reset_oscs()callspcm_unload_all_presets()As a result, the same PCM note can produce different audio depending on when
the pending reset executes.
Patch loading already prevents the equivalent ordering race by calling
amy_execute_deltas()immediately beforepatches_load_patch()(#372).This change applies the same ordering boundary immediately before
pcm_load().Only due events are executed; future scheduled events remain queued.
Regression test
The existing
TestLoadSamplegolden test now resets AMY immediately beforeloading its sample.
Before the fix:
After the fix:
The existing reference WAV does not change.
Test plan
python3 -m amy.test quiet— 119 tests passmake check-c-apimake web— not run locally becauseemccis unavailable; covered by CI