[5/6] Add a dedicated asset generation toolbar - #161
Merged
Conversation
dazzatronus
force-pushed
the
derk/sdk-generation-toolbar
branch
from
August 25, 2026 00:31
fdbe0b6 to
95e2932
Compare
dazzatronus
force-pushed
the
derk/sdk-generation-toolbar
branch
from
August 25, 2026 01:28
95e2932 to
c186d6c
Compare
dazzatronus
force-pushed
the
derk/sdk-generation-toolbar
branch
2 times, most recently
from
August 25, 2026 04:41
32bf05e to
7e99d7e
Compare
dazzatronus
force-pushed
the
derk/sdk-generation-toolbar
branch
from
August 25, 2026 06:02
7e99d7e to
315f2ed
Compare
dazzatronus
changed the title
dazzatronus
force-pushed
the
derk/sdk-generation-toolbar
branch
from
August 25, 2026 06:18
315f2ed to
1ae972d
Compare
dazzatronus
force-pushed
the
derk/sdk-generation-toolbar
branch
from
August 25, 2026 06:31
1ae972d to
2825b7b
Compare
dazzatronus
force-pushed
the
derk/sdk-generation-toolbar
branch
from
August 25, 2026 06:58
2825b7b to
ba79fc8
Compare
dazzatronus
force-pushed
the
derk/sdk-generation-toolbar
branch
2 times, most recently
from
August 25, 2026 07:32
63996a7 to
e5a2134
Compare
dazzatronus
force-pushed
the
derk/sdk-generation-toolbar
branch
from
August 25, 2026 09:12
e5a2134 to
f7e901a
Compare
dazzatronus
force-pushed
the
derk/sdk-generation-toolbar
branch
from
August 25, 2026 09:35
f7e901a to
d759182
Compare
dazzatronus
force-pushed
the
derk/sdk-generation-toolbar
branch
2 times, most recently
from
August 25, 2026 10:27
a271288 to
93d58ea
Compare
dazzatronus
force-pushed
the
derk/sdk-generation-toolbar
branch
2 times, most recently
from
August 25, 2026 10:31
101613d to
060031f
Compare
dazzatronus
force-pushed
the
derk/sdk-generation-toolbar
branch
from
August 25, 2026 11:56
060031f to
23584ef
Compare
dazzatronus
force-pushed
the
derk/sdk-generation-toolbar
branch
from
August 25, 2026 11:59
23584ef to
d7bb93d
Compare
dazzatronus
force-pushed
the
derk/sdk-generation-toolbar
branch
from
August 25, 2026 12:03
d7bb93d to
a66aa15
Compare
dazzatronus
force-pushed
the
derk/sdk-generation-toolbar
branch
from
August 25, 2026 12:06
a66aa15 to
ba94baf
Compare
|
🎉 This PR is included in version 2.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompt generation needs a dedicated editing surface while asset properties and clip timing remain reachable.
A third toolbar mode contains the inline prompt, Generate/Retry state and error feedback. The controller routes mode changes and keeps generation markers synchronised across every mounted toolbar.
This is 736 lines because the toolbar DOM and state synchronisation, controller routing, shared mode CSS and interaction tests share one mount/dispose contract. The decisions sit in
generate-toolbar.tsandui-controller.ts; mirrored toolbar markup, CSS and tests are integration churn. Splitting at those boundaries leaves either an unreachable pane or listeners without an owner.Verify:
npm run verify:ci