Skip to content

Add test scope to hamcrest dependency#428

Merged
petrberan merged 1 commit intoshrinkwrap:masterfrom
nlisker:patch-1
Jan 30, 2026
Merged

Add test scope to hamcrest dependency#428
petrberan merged 1 commit intoshrinkwrap:masterfrom
nlisker:patch-1

Conversation

@nlisker
Copy link
Contributor

@nlisker nlisker commented Nov 6, 2025

Hamcrest isn't declared as test dependency, which causes it to be pulled into a shrinkwrap archive.

@nlisker
Copy link
Contributor Author

nlisker commented Nov 6, 2025

Thanks for the quick review, @lprimak, but we need someone with write access and I don't think such a person will be made available hastily considering that the last commit was 8 months ago :)
I will let this marinate until next week before I try to pull someone to look at this, unless you know of another way.

@lprimak
Copy link
Contributor

lprimak commented Nov 6, 2025

I'll happily become a committer if you could arrange it somehow

@petrberan
Copy link
Member

Hi there @lprimak @nlisker , sorry about being absent for the past couple of months. Our entire business unit got moved to a different company, we had to settle in, we're switching to a different infrastructure, our Nexus got decommissioned and we had to tackle many more challenges along the way.

That being said, we didn't forget about Shrinkwrap :) Still got in on my to-do list and in the upcoming weeks I'd like to ask some of my colleagues to help me maintain it, now that the dust is settling down. Just please bear with me for the time being

@petrberan petrberan merged commit dab5896 into shrinkwrap:master Jan 30, 2026
3 checks passed
@rhusar
Copy link
Member

rhusar commented Jan 30, 2026

@petrberan We still don't have access to this ShrinkWrap organization, so that's what's blocking the rest of us working here...

@petrberan
Copy link
Member

I'm hoping that this week I'll resolve the issue with releasing a new version and new SET member will take over Shrinkwrap @rhusar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants