Add optional chars argument to String#strip, #lstrip, and #rstrip #66
+196
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enhancement allows specifying a custom set of characters to remove
from strings instead of only whitespace characters.
Examples:
"---abc+++".strip("-+") # => "abc"
"---abc+++".lstrip("-") # => "abc+++"
"---abc+++".rstrip("+") # => "---abc"
The implementation:
- Adds char_in_string() helper to check if a character is in the set
- Adds lstrip_offset_chars() and rstrip_offset_chars() for custom char removal
- Updates strip, lstrip, rstrip and their bang variants to accept optional chars arg
- Maintains backward compatibility when no argument is provided
- Properly handles multibyte characters with encoding awareness
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Use the existing tr_setup_table() and tr_find() functions from String#tr implementation to optimize character lookups in strip/lstrip/rstrip with chars argument. Benefits: - O(1) lookup for ASCII characters (< 256) using lookup table - Hash-based lookup for multibyte characters - Consistent with String#tr and String#delete implementations - Much faster than linear search through chars string Changes: - Remove char_in_string() function (replaced by tr_find()) - Use tr_setup_table() to build character lookup table - Use tr_find() for fast character membership testing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhancement allows specifying a custom set of characters to remove from strings instead of only whitespace characters.
Examples:
"---abc+++".strip("-+") # => "abc"
"---abc+++".lstrip("-") # => "abc+++"
"---abc+++".rstrip("+") # => "---abc"
The implementation:
🤖 Generated with Claude Code