Skip to content

fix: workflow optimization and GitHub CLI fixes#16

Merged
shunkakinoki merged 6 commits into
mainfrom
fix-workflow-optimization
Sep 21, 2025
Merged

fix: workflow optimization and GitHub CLI fixes#16
shunkakinoki merged 6 commits into
mainfrom
fix-workflow-optimization

Conversation

@shunkakinoki

Copy link
Copy Markdown
Owner

Changes Made

  • Updated Bun workflow to use setup-bun action for better reliability
  • Fixed GitHub CLI PR merge command syntax in documentation
  • Streamlined command arguments in configuration files
  • Added auto-squashing guidance and script prohibition rules

Technical Details

  • Migrated from manual Bun setup to GitHub's setup-bun action
  • Corrected invalid --delete-branch=false syntax to proper boolean flags
  • Improved PR creation workflow documentation with accurate CLI commands
  • Enhanced configuration file consistency across different editor setups

Testing

  • All pre-commit hooks pass (Biome formatting, linting)
  • GitHub Actions workflows validated
  • CLI commands tested for syntax correctness
  • Documentation updates verified for accuracy

🤖 Generated with Claude

- Replace separate Bun setup and install steps with custom composite action
- Use shunkakinoki/actions/.github/actions/auto-merge composite action
- Reduces workflow complexity and improves maintainability
- Replace auto-merge action with setup-bun action in the Bun workflow
- Ensures proper setup of Bun environment for CI/CD processes
- Maintains consistency with recent changes to the workflow structure
- Add OBJECTIVE section with critical rule prohibiting script creation
- Add Step 6: Auto Squashing functionality for /pr-create auto command
- Update complete example to include auto-squashing workflow
- Explicitly prohibit creating new script files resembling pr-create
- Strictly limit usage to GitHub PR creation workflow only
- Consolidate command argument formatting across multiple JSON configuration files
- Remove unnecessary line breaks for improved readability
- Ensure consistency in argument structure for MCP server commands

This update enhances the clarity and maintainability of configuration files related to MCP servers.
Copilot AI review requested due to automatic review settings September 21, 2025 20:58

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Comment thread commands/pr-create.md

# To delete branch after merge, add --delete-branch flag
gh pr merge <pr-number> --squash --delete-branch
```

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: PR Workflow Error: Premature Merge Commands

The PR creation workflow incorrectly includes gh pr merge commands (e.g., --squash, --delete-branch) as Step 6. This instructs users to immediately merge a PR before review and approval, creating an impossible or undesirable workflow. Additionally, the /pr-create auto variant is mentioned without explanation.

Fix in Cursor Fix in Web

Co-authored-by: shunkakinoki <shunkakinoki@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@shunkakinoki
shunkakinoki merged commit 4c9c5b5 into main Sep 21, 2025
2 checks passed
@shunkakinoki
shunkakinoki deleted the fix-workflow-optimization branch September 21, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants