Allow alternativ configuration for ETHEREUM_WS #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradkonrad
changed the title
ylembachar
reviewed
Mar 25, 2025
Contributor
ylembachar
left a comment
ylembachar
left a comment
There was a problem hiding this comment.
Looks good to me, if you could also update the README to explain that the websocket RPC needs only to be set if one is not using the staker configuration? Thank you.
konradkonrad
force-pushed
the
rpc_configuration
branch
3 times, most recently
from
37d6593 to
392f998
Compare
ylembachar
approved these changes
Apr 28, 2025
konradkonrad
force-pushed
the
rpc_configuration
branch
from
4b2783e to
302d123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8