-
Notifications
You must be signed in to change notification settings - Fork 3
added loki logging configuration for api keypers #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a5e71cb
added loki logging configuration for api keypers
blockchainluffy a7b7388
updated readme to include step to install lock docker driver
blockchainluffy 20cd594
updated 'update' section of readme to include push logs cmd
blockchainluffy 5067a4c
added readme section for update to setup loki
blockchainluffy eb966b5
added kpr prefix for keyper name
blockchainluffy 1639df5
update readme
f41e9df
Apply suggestions from code review
ylembachar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| services: | ||
| chain: | ||
| logging: !override | ||
| driver: loki | ||
| options: | ||
| loki-url: ${LOKI_URL} | ||
| loki-external-labels: keyper_name=kpr-${KEYPER_NAME} | ||
|
|
||
| keyper: | ||
| logging: !override | ||
| driver: loki | ||
| options: | ||
| loki-url: ${LOKI_URL} | ||
| loki-external-labels: keyper_name=kpr-${KEYPER_NAME} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to move this installation step under Software requirements, and then perhaps again before running docker compose up (and before updating) in the readme, so users know they should be installing the driver if they want to enable logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated readme