FIX: humanizer units format according to humanize-duration v3.1.0+ #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed moment.locale setting to prevent unwanted side effects on users moment.locale settings.
Contributor
Author
|
@siddii Also please, consider to add |
… into fix_humanize-duration-3.1.0-compatibility
… into fix_humanize-duration-3.1.0-compatibility
Contributor
Author
|
@siddii is possible to update the version to 1.3.5 with a tag and update also npm accordingly? Thanks |
Owner
|
@simonemazzoni - Its tagged and published on npm - https://www.npmjs.com/package/angular-timer Sorry for the delay. |
Contributor
Author
|
Great!! Thanks ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this PR resolve the issue that causes the library not to work properly with updated versions of humanize-duration as pointed in #222
The fix is pretty simple as you can see from the code.
I also removed the
moment.locale(this.language)line to prevent unwanted side effects on users moment.locale settings since it sets the language globally.It is better to tell users to set the language themselves invoking a
moment.locale('wanted_language_code')instead of force it from the directive.Hope this is good with you.
Let me know if there are questions.
Please, can also update the npm package?
Thanks
Simone